Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix list space permissions #3084

Merged
merged 6 commits into from
Jul 18, 2022
Merged

Fix list space permissions #3084

merged 6 commits into from
Jul 18, 2022

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Jul 18, 2022

No description provided.

@butonic
revert logic change
f716fd3 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
fix typo
25709d7 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@update-docs
Copy link

update-docs bot commented Jul 18, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic changed the base branch from master to edge July 18, 2022 09:05
@butonic
fix v2.7.1 changelog
93f2d85 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the fix-list-space-permissions branch from 8def106 to 93f2d85 Compare July 18, 2022 09:06
@butonic
add changelog
caca92f 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
fill in storage provider id if it is missing
9e68319 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the fix-list-space-permissions branch from 95ef49d to 9e68319 Compare July 18, 2022 11:12
dragotin
dragotin reviewed Jul 18, 2022
View reviewed changes
Copy link
Contributor

@dragotin dragotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two little nitpicks.

pkg/storage/utils/decomposedfs/spaces.go Show resolved Hide resolved
pkg/storage/utils/decomposedfs/spaces.go Show resolved Hide resolved
@butonic
update changelog reflect all commits
0104218 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@micbar micbar requested a review from dragotin July 18, 2022 12:16
@butonic butonic merged commit 6b31c62 into cs3org:edge Jul 18, 2022
@butonic butonic deleted the fix-list-space-permissions branch July 18, 2022 12:37
@micbar micbar mentioned this pull request Jul 19, 2022
Closed
36 tasks
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@dragonchaser dragonchaser dragonchaser approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@wkloucek wkloucek Awaiting requested review from wkloucek

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

@dragotin dragotin Awaiting requested review from dragotin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@butonic @dragonchaser @dragotin @micbar